Spec for opcode EXTCODESIZE#53
Closed
silathdiir wants to merge 1 commit into
Closed
Conversation
DreamWuGit
reviewed
Dec 12, 2022
| # If witness value `exists == 1`, lookup both account `code_hash` and | ||
| # `code_size` (has one more lookup). Otherwise lookup account | ||
| # non-existing proof. | ||
| rw_counter=Transition.delta(7 + exists), |
There was a problem hiding this comment.
seems rw_counter is incorrect, it doesn't count bytecode lookups in .
Author
There was a problem hiding this comment.
Delete wrong count of bytecode lookup for rw_counter. Thanks a lot 🙏
DreamWuGit
reviewed
Dec 14, 2022
| - gas: | ||
| - the accessed `address` is warm: WARM_STORAGE_READ_COST | ||
| - the accessed `address` is cold: COLD_ACCOUNT_ACCESS_COST | ||
| 3. Lookups: 8 bus-mapping lookups if account exists otherwise 7 |
DreamWuGit
reviewed
Dec 14, 2022
| rand_address(), | ||
| rand_bytes(100), | ||
| rand_range(2), | ||
| rand_range(2) == 0, |
There was a problem hiding this comment.
rand_range(2) generates 0 or 1 ? if so, do not need check ==0
DreamWuGit
reviewed
Dec 14, 2022
| tx_id = 1 | ||
| call_id = 1 | ||
|
|
||
| # 7 + 1 reversible operation (the account access list write) |
There was a problem hiding this comment.
I think you can only consider successful state if fail , we will handle it in error circuit
silathdiir
force-pushed
the
feat/opcode-extcodesize
branch
from
cb6ab2e to
8f1cb9f
Compare
silathdiir
force-pushed
the
feat/opcode-extcodesize
branch
from
3a0b4ee to
b4e9073
Compare
Author
|
Thanks dream's code review. Moved to upstream privacy-ethereum#341 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related upstream issue privacy-ethereum#327
It is similar as EXTCODEHASH and BALANCE (used
existswitness value).