This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Consolidate MPT update lookups in state circuit#236
Merged
z2trillion merged 15 commits intoAug 28, 2022
Conversation
This was referenced Jul 26, 2022
Contributor
|
Could you update
Thanks! |
Contributor
|
@z2trillion please ping me once this PR is ready for review (no longer draft). |
Contributor
Author
|
@ed255, sorry about that. I realized that I had forgotten to change the state roots in the assignment function. |
Contributor
ah no worries :) |
Contributor
Author
|
@ed255, when will you be able to take a look at this? |
CPerezz
requested review from
CPerezz and
miha-stopar
and removed request for
CPerezz
ed255
reviewed
Aug 18, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
In general look good but I believe a constraint is missing to limit when the root value can be changed.
miha-stopar
reviewed
Aug 18, 2022
Contributor
miha-stopar
left a comment
miha-stopar
left a comment
There was a problem hiding this comment.
LGTM, but agree with Edu's comment.
Merged
Co-authored-by: Eduard S. <eduardsanou@posteo.net>
Co-authored-by: Eduard S. <eduardsanou@posteo.net>
lispc
approved these changes
Aug 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only make one mpt update lookup per access group in the state circuit, which allows us to remove the mpt counter