Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Add mpt updates to the state circuit#766

Merged
z2trillion merged 8 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/mpt_lookup2
Sep 16, 2022
Merged

Add mpt updates to the state circuit#766
z2trillion merged 8 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/mpt_lookup2

Conversation

@z2trillion
Copy link
Copy Markdown
Contributor

@z2trillion z2trillion commented Sep 14, 2022

Same functionality as #621, but built from scratch because of changes to main.

closes #607
specs: privacy-ethereum/zkevm-specs#236

@z2trillion z2trillion requested a review from a team September 14, 2022 22:05
@github-actions github-actions Bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Sep 14, 2022
@z2trillion z2trillion requested review from ed255 and lispc September 14, 2022 22:05
Comment thread zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated
Comment thread zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated
Comment thread zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated
Comment thread zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated
Comment thread zkevm-circuits/src/state_circuit/constraint_builder.rs
Comment thread zkevm-circuits/src/state_circuit/constraint_builder.rs
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I've left some comments, please take a look :)

Comment thread zkevm-circuits/src/witness/mpt.rs Outdated
Comment thread zkevm-circuits/src/witness/mpt.rs Outdated
Comment thread zkevm-circuits/src/witness/mpt.rs Outdated
Comment thread zkevm-circuits/src/state_circuit/test.rs
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

Copy link
Copy Markdown
Collaborator

@miha-stopar miha-stopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@z2trillion z2trillion merged commit fcec3b0 into privacy-ethereum:main Sep 16, 2022
@z2trillion z2trillion deleted the feat/mpt_lookup2 branch September 16, 2022 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

crate-zkevm-circuits Issues related to the zkevm-circuits workspace member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

State circuit - MPT circuit integration

3 participants