Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

revise log state constrain according to circuit implementation #220

Merged
icemelon merged 10 commits into
privacy-ethereum:masterfrom
scroll-tech:log_state
Jun 29, 2022
Merged

revise log state constrain according to circuit implementation #220
icemelon merged 10 commits into
privacy-ethereum:masterfrom
scroll-tech:log_state

Conversation

@DreamWuGit
Copy link
Copy Markdown
Collaborator

in circuit implementation there are some minor changes to raw spec, do update in this PR .
circuit implementation: privacy-ethereum/zkevm-circuits#552

@DreamWuGit
Copy link
Copy Markdown
Collaborator Author

@ed255 Could you pls. have a look ? Thx !

Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/state.py Outdated
@ed255
Copy link
Copy Markdown
Contributor

ed255 commented Jun 23, 2022

Before approving this I would like to discuss the topic of redundant constraints; in particular the field_tag-specific constraints. This is also related to privacy-ethereum/zkevm-circuits#552

Maybe it's worth removing the redundant constraints now instead of doing it later, mainly so that the state circuit implementation doesn't grow in columns and/or degree. I'm talking specifically about the field_tag-specific constraints, which require using a selector expression. I discussed this topic with @z2trillion via chat and would like to continue it here.

@DreamWuGit
Copy link
Copy Markdown
Collaborator Author

Before approving this I would like to discuss the topic of redundant constraints; in particular the field_tag-specific constraints. This is also related to privacy-scaling-explorations/zkevm-circuits#552

Maybe it's worth removing the redundant constraints now instead of doing it later, mainly so that the state circuit implementation doesn't grow in columns and/or degree. I'm talking specifically about the field_tag-specific constraints, which require using a selector expression. I discussed this topic with @z2trillion via chat and would like to continue it here.

I am OK with it because it indeed increases much complexity, I will comment them with that issue #221

@DreamWuGit
Copy link
Copy Markdown
Collaborator Author

@ed255 removed field_tag-specific constraints and test in c487d5c & 72c84a0

Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/zkevm_specs/state.py Outdated
Comment thread src/zkevm_specs/evm/instruction.py Outdated
Copy link
Copy Markdown
Contributor

@miha-stopar miha-stopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icemelon icemelon merged commit 4008d54 into privacy-ethereum:master Jun 29, 2022
@icemelon icemelon deleted the log_state branch June 29, 2022 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants