Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

CALLDATACOPY: Read from caller's memory for internal call#178

Merged
ChihChengLiang merged 2 commits into
privacy-ethereum:masterfrom
scroll-tech:fix/calldatacopy-internal
Apr 11, 2022
Merged

CALLDATACOPY: Read from caller's memory for internal call#178
ChihChengLiang merged 2 commits into
privacy-ethereum:masterfrom
scroll-tech:fix/calldatacopy-internal

Conversation

@roynalnaruto
Copy link
Copy Markdown
Collaborator

@roynalnaruto roynalnaruto commented Apr 9, 2022

Copy link
Copy Markdown
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot to fix this! There is a small issue of reading CallDataLength from tx_table, except that all look good to me!

Comment thread src/zkevm_specs/evm/execution/calldatacopy.py Outdated
Copy link
Copy Markdown
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Copy Markdown
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChihChengLiang ChihChengLiang merged commit a20ba27 into privacy-ethereum:master Apr 11, 2022
@roynalnaruto roynalnaruto deleted the fix/calldatacopy-internal branch August 22, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CALLDATACOPY should read caller's memory

3 participants