CALLDATACOPY: Internal call and refactoring

[roynalnaruto]

Addresses and closes: privacy-ethereum/zkevm-specs#134

Specs PR:

• CALLDATACOPY: Read from caller's memory for internal call zkevm-specs#178

This PR:

• Refactors CALLDATACOPY based on CALLDATACOPY: Read from caller's memory for internal call zkevm-specs#178
• Tests internal calls to CALLDATACOPY where is_root: false
• Fixes get_fixed_tables

[roynalnaruto]

@han0110 #434 (comment)

[roynalnaruto]

@han0110 I've updated the bus-mapping tests for CALLDATACOPY to test an internal call case:
https://github.com/scroll-tech/zkevm-circuits/blob/fix/calldatacopy-internal/bus-mapping/src/evm/opcodes/calldatacopy.rs#L201

which passes as expected.

Although the same test fails in the evm_circuit/execution module:
https://github.com/scroll-tech/zkevm-circuits/blob/fix/calldatacopy-internal/zkevm-circuits/src/evm_circuit/execution/calldatacopy.rs#L500

with this error:

`Err([Lookup { name: "LOOKUP: \"Fixed table\"", lookup_index: 33, location: InRegion { region: Region { index: 5, name: "Execution step" }, offset: 176 } }, Lookup { name: "LOOKUP: \"Fixed table\"", lookup_index: 38, location: InRegion { region: Region { index: 5, name: "Execution step" }, offset: 176 } }, Lookup { name: "LOOKUP: \"Bytecode table\"", lookup_index: 162, location: InRegion { region: Region { index: 5, name: "Execution step" }, offset: 288 } }])`

Do you know what might be the issue here?

[han0110]

1. I forgot to update the get_fixed_table to have Range64 and Range1024 (my apology), so 2 fixed_table lookup in CALL failed. Adding them should remove first 2 failures.
2. Currently STOP can't handle index bytecode out of range, so the bytecode_table lookup failed. Adding a STOP after https://github.com/scroll-tech/zkevm-circuits/blob/fix/calldatacopy-internal/zkevm-circuits/src/evm_circuit/execution/calldatacopy.rs#L533 should remove the last failure.

[roynalnaruto]

Should I update get_fixed_table and commit in this PR?

[han0110]

Yes, let's fix it in this PR. Thanks!

[icemelon]

Thanks for implementing this. Overall LGTM. Just one minor comment

[roynalnaruto]

@han0110 This is ready to be reviewed again. All changes included from my end.

[han0110]

LGTM! Thanks!