geth-utils: remove 10mb trace limit

[pinkiebell]

I hit this one while testing the circuits

[han0110]

@adria0 I saw this limitation is added in #748, is there anything broken when the trace is too large? Otherwise I think it should be fine to process large trace.

[adria0]

@adria0 I saw this limitation is added in #748, is there anything broken when the trace is too large? Otherwise I think it should be fine to process large trace.

Yes, @han0110 happened that there was a crash when rust allocated a ton of memory to deserialize the geth full trace.
Anyway @pinkiebell we can remove this at this moment because now there's a configuration file in the testool that allows to ignore specific tests.

[ed255]

I think that after this was merged some months ago #614 we shouldn't encounter massive memory usage in the traces (as I believe this was coming from having a memory snapshot at each step of the trace). We just need to make sure that we're always querying the trace with EnableMemory: false. I think this may not be the case when using the internal tracer. See: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/2235254416aefd1bc9b5592e4e06cd58f8516e2a/external-tracer/src/lib.rs#L48

@pinkiebell could you try setting the default enable_memory to false and see if all unit tests still pass?

[ed255]

LGTM! I think that without memory snapshots this check is unnecessary. (We may still need to update some places to avoid requesting the memory snapshots from the trace)

[pinkiebell]

I think that after this was merged some months ago #614 we shouldn't encounter massive memory usage in the traces (as I believe this was coming from having a memory snapshot at each step of the trace). We just need to make sure that we're always querying the trace with EnableMemory: false. I think this may not be the case when using the internal tracer. See:

https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/2235254416aefd1bc9b5592e4e06cd58f8516e2a/external-tracer/src/lib.rs#L48

@pinkiebell could you try setting the default enable_memory to false and see if all unit tests still pass?

Looks good 👌

[han0110]

LGTM!