This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Official ethereum/tests StateTests execution (final)#748
Merged
Conversation
added 4 commits
September 13, 2022 12:56
…circuits into evm-testvectors3
08bb9f7 to
ef4b6bb
Compare
ChihChengLiang
approved these changes
Sep 14, 2022
Collaborator
ChihChengLiang
left a comment
There was a problem hiding this comment.
LGTM too! Awesome work @adria0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR supersedes #382
Note for reviewers
You will find in this PR:
A binary in
evm-testvectors/src/main.rsthatevm-testvectors/testfolder that is a git submodulejsonand.yamlcode.cachefiledockerfolder)results.cachefile, but skips some testsOPCODES_UNIMPLEMENTEDconst) via scanning the geth traceStateTestConfig)geth-utils/lib/lib.goto skip very big traces (geth crashed)FILE_IGNORE_LIST)results.cachefileEnrich
Bytecodeby adding adisasm() -> Stringmethod as also aniter()that generates an iterator over the bytecode Opcodes. From my previous experience running those tests there are is a lot of cases that you have to analyze and test the code, and I created a small command line tool for generating on-the-fly tests using assembly/bytecode as also to parse bytecode (see--rawoption inmain.rs)note that this is a first version, probally this is going to change, and eventually we have to move this into a specific repo, but for the moment I prefer to merge this to not having code far from origin/main
note2 this code is not critical at this point, so a light review could be done IMO