This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Add Scroll reviewers team as codeowners#438
Closed
CPerezz wants to merge 1 commit into
Closed
Conversation
Adds `scroll-tech/zkevm-reviewers` to CODEOWNERS file to be requested for reviews of: - zkevm-circuits crate - bus-mapping crate This is a follow-up PR of #429
ed255
approved these changes
Apr 8, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM! Allowing people from scroll-tech to review and approve PRs formally will allow us to handle PRs more efficiently :)
Contributor
Author
|
Superset by #446 |
CPerezz
added a commit
that referenced
this pull request
Apr 13, 2022
* feat: Add PR requester for external reviewers Deprecates #438 and instead adds the external_reviewers to the PR reviews using a 3rd party application. That is done like this to avoid including a lot of people into `appliedzkp` org and granting custom permissions each time we want to add a new reviewer. Resolves: #429 completely. * Trigger workflow only when PR is opened Force-pushing to the PR currently re-triggers the workflow by assigning to the PR a new member of the team while mantaining the previous. That's an issue as we end up with multiple reviewers on each PR when indeed we just need one. See: uesteibar/reviewer-lottery#26 for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
scroll-tech/zkevm-reviewersto CODEOWNERS fileto be requested for reviews of:
This is a follow-up PR of #429
Required before merge
@ChihChengLiang @barryWhiteHat to be able to merge this, @scroll-tech/zkevm-reviewers needs to be granted write permissions to the repository.