This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Add CODEOWNERS file to repo to auto-assign reviews#429
Merged
Conversation
CPerezz
force-pushed
the
auto_reviews
branch
3 times, most recently
from
adfffdc to
523eb43
Compare
Since the solution #428 is impossible to implement as a bug affecting the gh actions prevents it. An alternative to automatically assign reviews for the reviewing team is to use a CODEOWNERS file. So this PR adds this file configured to assign all reviews to `appliedzkp/zkevm-reviewers` and also Miha specifically to any state circuit PR. Resolves: #423
CPerezz
added a commit
that referenced
this pull request
Apr 7, 2022
Adds `scroll-tech/zkevm-reviewers` to CODEOWNERS file to be requested for reviews of: - zkevm-circuits crate - bus-mapping crate This is a follow-up PR of #429
CPerezz
added a commit
that referenced
this pull request
Apr 7, 2022
Adds `scroll-tech/zkevm-reviewers` to CODEOWNERS file to be requested for reviews of: - zkevm-circuits crate - bus-mapping crate This is a follow-up PR of #429
CPerezz
added a commit
that referenced
this pull request
Apr 13, 2022
* feat: Add PR requester for external reviewers Deprecates #438 and instead adds the external_reviewers to the PR reviews using a 3rd party application. That is done like this to avoid including a lot of people into `appliedzkp` org and granting custom permissions each time we want to add a new reviewer. Resolves: #429 completely. * Trigger workflow only when PR is opened Force-pushing to the PR currently re-triggers the workflow by assigning to the PR a new member of the team while mantaining the previous. That's an issue as we end up with multiple reviewers on each PR when indeed we just need one. See: uesteibar/reviewer-lottery#26 for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the solution #428 is impossible to implement as a bug affecting
the gh actions prevents it.
An alternative to automatically assign reviews for the reviewing team is
to use a CODEOWNERS file.
So this PR adds this file configured to assign all reviews to
appliedzkp/zkevm-reviewersand also Miha specifically to any statecircuit PR.
Resolves: #423