This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Conversation
github-actions
Bot
added
crate-bus-mapping
This module was tending to grow into a monster as `mock/lib.rs` was in the past due to the fact that a lot of functions were being created with minimal customizations from the generic simple calls. Instead, the idea would be that on each test the ctx is written. And to not make it super verbose, `TestContext::simple_ctx_with_bytecode` has been implemented. Then, all of the tests that were able to have simpler and easier config calls have been created.
Co-authored-by: Han <tinghan0110@gmail.com>
This was referenced Apr 4, 2022
Merged
ed255
approved these changes
Apr 4, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM! Nice work on the simplification of the testing utilities :D
|
|
||
| assert_eq!( | ||
| run_test_circuits( | ||
| TestContext::<2, 1>::simple_ctx_with_bytecode(bytecode).unwrap(), |
Contributor
There was a problem hiding this comment.
I have to say that it's a bit strange specifying the ::<2,1> because the simple_ctx_with_bytecode is not generic and doesn't require self. But without it, the code doesn't compile. So I don't have any solution for this :P
Contributor
Author
There was a problem hiding this comment.
It surprised me a lot too!! It's a weird const_generics property that I did not see before.
zemse
pushed a commit
to zemse/zkevm-circuits
that referenced
this pull request
Mar 22, 2023
* add invalid creation code circuit * remove outdated todo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds an implementation for GASPRICE bus-mapping opcode and the zkevm-circuits gadget structure.
Also, it adds a simplification on the testing utilities in
zkevm-circuitsin 0fea7a8