Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

ORIGIN opcode#360

Merged
CPerezz merged 6 commits into
mainfrom
origin-opcode
Apr 5, 2022
Merged

ORIGIN opcode#360
CPerezz merged 6 commits into
mainfrom
origin-opcode

Conversation

@ChihChengLiang
Copy link
Copy Markdown
Collaborator

@ChihChengLiang ChihChengLiang commented Mar 1, 2022

Spec privacy-ethereum/zkevm-specs#128

Edit(1)

@github-actions github-actions Bot added the crate-bus-mapping Issues related to the bus-mapping workspace member label Mar 1, 2022
@github-actions github-actions Bot added T-opcode Type: opcode-related and focused PR/Issue crate-zkevm-circuits Issues related to the zkevm-circuits workspace member labels Mar 1, 2022
@ChihChengLiang
Copy link
Copy Markdown
Collaborator Author

This is blocked by mocking the tx sender address. Will hold until #349 is completed.

@CPerezz CPerezz mentioned this pull request Mar 4, 2022
19 tasks
@github-actions github-actions Bot removed the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Apr 4, 2022
@CPerezz CPerezz marked this pull request as ready for review April 4, 2022 11:28
@CPerezz CPerezz requested review from ed255 and han0110 April 4, 2022 11:28
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Modulo the inclusion of the test update from #422

Copy link
Copy Markdown
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread zkevm-circuits/src/evm_circuit/execution/origin.rs Outdated
@CPerezz CPerezz merged commit 12e21ff into main Apr 5, 2022
@CPerezz CPerezz deleted the origin-opcode branch April 5, 2022 09:30
zemse pushed a commit to zemse/zkevm-circuits that referenced this pull request Mar 22, 2023
* fix

* fix memory.copy_from

* many fixes

* Update common_gadget.rs

* Fix clippy.

---------

Co-authored-by: Steven Gu <asongala@163.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants