Revert "Improve memory allocation when generating expression identifier"#119
Closed
adria0 wants to merge 1 commit into
Closed
Revert "Improve memory allocation when generating expression identifier"#119adria0 wants to merge 1 commit into
adria0 wants to merge 1 commit into
Conversation
|
Why should #115 be reverted?? |
Author
|
Haha, this is something that github created automatically. I remove it.! |
iquerejeta
pushed a commit
to input-output-hk/halo2
that referenced
this pull request
May 8, 2024
…ure/builder-pattern-for-poseidon-duplex Resolve "Use builder pattern for constructing Poseidon duplex patterns"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #115