Improve memory allocation when generating expression identifier#115
Merged
Conversation
adria0
force-pushed
the
feat/challenge-evm-helpers
branch
from
fcee9f2 to
c8108c2
Compare
- Adds a `transpose` method to turn `Value<Result<_>>` into `Result<Value<_>>` - `Expression::identifier()` remove string memory reallocation
adria0
force-pushed
the
feat/challenge-evm-helpers
branch
from
c8108c2 to
551c782
Compare
CPerezz
reviewed
Jan 3, 2023
han0110
approved these changes
Jan 9, 2023
adria0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the the implementation of the EVM ChallengeAPI, implement the following improvements:
Expression::identifier()remove string memory reallocationAdds atransposemethod to turnValue<Result<_>>intoResult<Value<_>>ImplementsPartialOrdforValue<F>