Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ls): preview features regex #1742

Merged
merged 4 commits into from
May 28, 2024
Merged

fix(ls): preview features regex #1742

merged 4 commits into from
May 28, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented May 27, 2024

fixes #1741

@Druue Druue added this to the 5.15.0 milestone May 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

🤖 Pull request artifacts

empty string

file commit
prisma.vsix cdc4795

github-actions bot added a commit that referenced this pull request May 27, 2024
@github-actions
Upload pull-request-artifacts/pr1742-prisma.vsix (6f095)
7fa03b0 
Pull request: #1742
Commit: 6f09510
@github-actions GitHub Actions
Copy link

Try this extension build via GitPod

Jolg42
Jolg42 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be best with a small test if possible.

github-actions bot added a commit that referenced this pull request May 28, 2024
@github-actions
Upload pull-request-artifacts/pr1742-prisma.vsix (e5a8e)
10bd947 
Pull request: #1742
Commit: e5a8e0c
github-actions bot added a commit that referenced this pull request May 28, 2024
@github-actions
Upload pull-request-artifacts/pr1742-prisma.vsix (0949b)
6dcc292 
Pull request: #1742
Commit: 0949b5c
@Druue Druue merged commit 28f5fa6 into main May 28, 2024
6 checks passed
@Druue Druue deleted the fix/1741 branch May 28, 2024 08:53
github-actions bot added a commit that referenced this pull request May 28, 2024
@github-actions
Upload pull-request-artifacts/pr1742-prisma.vsix (cdc47)
7dbc160 
Pull request: #1742
Commit: cdc4795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.15.0
Development

Successfully merging this pull request may close these issues.

We incorrectly read commented out preview features if they are before the real preview features
2 participants
@Druue @Jolg42