Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We incorrectly read commented out preview features if they are before the real preview features #1741

Closed
Druue opened this issue May 27, 2024 · 0 comments · Fixed by #1742
Closed
Assignees
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: autocompletion LSP text document completion
Milestone

Comments

@Druue
Copy link
Contributor

Druue commented May 27, 2024

Expected behavior

We should read the actual set of preview features

Prisma information

Screen.Recording.2024-05-27.at.19.16.13.mov
generator client {
  provider        = "prisma-client-js"
  // previewFeatures = []
  previewFeatures = ["views"]
}

datasource db {
  provider = "postgres"
  url      = env("DATABASE_URL")
}
@Druue Druue added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. topic: autocompletion LSP text document completion domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. labels May 27, 2024
@Druue Druue self-assigned this May 27, 2024
Druue added a commit that referenced this issue May 27, 2024
@Druue Druue added this to the 5.15.0 milestone May 27, 2024
Druue added a commit that referenced this issue May 28, 2024
* fix #1741
* Make preview features regex more tolerant of spacing

---------

Co-authored-by: Joël Galeran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: autocompletion LSP text document completion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant