Remove newline in file to revert accidental visual regression of Button #3912
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llastflowers
requested review from
Copilot and
hectahertz
and removed request for
Copilot
🦋 Changeset detectedLatest commit: edf2542 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Remove newline to fix visual regression in Button.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a visual regression in the Button component that was accidentally introduced in PR #3867. The regression was caused by an extra newline in the ERB template that resulted in unwanted whitespace in the rendered HTML, affecting the button's visual appearance.
Changes:
- Removed an extra blank line between the button's closing ERB tag and the paragraph element in the summary_as_button preview
- Added a changeset documenting the patch-level fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
previews/primer/beta/button_preview/summary_as_button.html.erb |
Removed blank line that was causing unwanted whitespace and visual regression |
.changeset/fast-cougars-repeat.md |
Added changeset entry documenting the patch-level fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
francinelucca
approved these changes
Feb 4, 2026
llastflowers
deleted the
llastflowers/patch/fix-minor-lookbook-regression
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Screenshots
Regressed button:
Fixed button:
Integration
N/A
List the issues that this change affects.
Closes https://github.com/github/primer/issues/6380
Risk Assessment
What approach did you choose and why?
The newline in this file interrupted the styling and caused the visual regression, so I removed the newline.
Anything you want to highlight for special attention from reviewers?
N/A
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.