Fix deprecation warning for Rails 9 #3898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7db2173 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joelhawksley
force-pushed
the
rails-9-dep
branch
from
0b08cd6 to
e8da149
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a deprecation warning by replacing ActionController::InvalidAuthenticityToken with ActionController::InvalidCrossOriginRequest in preparation for Rails 9, where the former will be removed.
Changes:
- Updated exception class from deprecated
InvalidAuthenticityTokentoInvalidCrossOriginRequest - Renamed handler method to match the new exception type
- Added changeset for patch version bump
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/controllers/primer/view_components/toggle_switch_controller.rb | Updated rescue_from handler to use new Rails exception class and renamed corresponding method |
| .changeset/few-seas-change.md | Added changeset documenting the deprecation fix for patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
DEPRECATION WARNING: ActionController::InvalidAuthenticityToken has been deprecated and will be removed in Rails 9.0. Use ActionController::InvalidCrossOriginRequest instead.Integration
Changes are for tests only.
Risk Assessment
Test-only.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.