-
Notifications
You must be signed in to change notification settings - Fork 132
Fix overlapping issue in TabNav at narrow viewports #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overlapping issue in TabNav at narrow viewports #3880
Conversation
🦋 Changeset detectedLatest commit: f1e5efa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Uh oh! @liuliu-dev, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an accessibility violation where tab navigation items overlapped at narrow viewport widths (320×256px), failing to meet WCAG 1.4.10 Reflow requirements.
Changes:
- Updated
.tabnav-tabsCSS to enable horizontal scrolling instead of hiding overflow - Added
flex-shrink: 0to child<li>elements to prevent tab collapse at narrow viewports
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/components/primer/alpha/tab_nav.pcss | Modified CSS to enable horizontal scrolling and prevent tab item shrinking at narrow viewports |
| .changeset/mighty-toys-remain.md | Added changeset documenting the patch-level fix for TabNav overlapping issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What are you trying to accomplish?
Fixes an accessibility issue where tab navigation items overlapped at narrow viewport widths (320×256px), failing WCAG 1.4.10 Reflow requirements.
Updated
.tabnav-tabsCSS to enable horizontal scrolling instead of hiding overflow, addedflex-shrink: 0to child<li>elements to prevent them from collapsingScreenshots
Integration
List the issues that this change affects.
Related issue: https://github.com/github/accessibility-audits/issues/14743
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.