Skip to content

Conversation

@llastflowers
Copy link
Contributor

What are you trying to accomplish?

  • Address a11y remediation issue
  • Make link distinguishable from surrounding text (other than color) by adding underline styling

Screenshots

Before and after:
link styling before
link styling after

Integration

N/A

List the issues that this change affects.

Relates to https://github.com/github/accessibility-audits/issues/14761

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Underline styling is the most common/simple way to address this issue, so I went that route.

Anything you want to highlight for special attention from reviewers?

N/A

Accessibility

Fix for a11y audit remediation issue

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@llastflowers llastflowers requested a review from a team as a code owner January 21, 2026 20:13
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

🦋 Changeset detected

Latest commit: 2296da4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an accessibility remediation issue by making links visually distinguishable from surrounding text through underline styling, ensuring compliance with accessibility standards that require links to be identifiable by more than color alone.

Changes:

  • Added inline underline styling to a link in the OcticonSymbols preview playground
  • Added changeset documentation for the patch release

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
previews/primer/alpha/octicon_symbols_preview/playground.html.erb Applied text-decoration: underline to MDN docs link
.changeset/proud-rocks-hide.md Added changeset entry documenting the accessibility fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@llastflowers llastflowers force-pushed the llastflowers/14761/link-distinction-fix branch from 3ecd649 to 7b6ec12 Compare January 21, 2026 20:22
Add underline styling to link for better visibility.
@llastflowers llastflowers added this pull request to the merge queue Jan 22, 2026
Merged via the queue into main with commit 391e438 Jan 22, 2026
32 checks passed
@llastflowers llastflowers deleted the llastflowers/14761/link-distinction-fix branch January 22, 2026 18:59
@primer primer bot mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants