Do not close dialog when clicking on the backdrop when it contains a form

[klaustopher]

What are you trying to accomplish?

The docs state that dialogs should not be closed when clicking on the backdrop, when the dialog contains a form:

By default, clicking on the backdrop will dismiss the dialog. However, if the dialog contains a form that can have unsaved changes, the backdrop won't dismiss the dialog, regardless of the state of the form.

This behavior was not implemented yet. The PR adds the check to the mouse click handler for the dialog that it is not automatically closed, when the dialog contains a form.

Screenshots

Monosnap.screencast.2025-02-18.09-43-15.mp4

Integration

As this fix implenents behavior that is already documented, IMHO no change to documentation is needed.

List the issues that this change affects.

Fixes #3214

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

As the docs state that regardless of the state of the form the dialog should not be closed, I did not implement any logic to do dirty tracking of the form or similar, instead I just check for existance of a form within the dialog and thus prevent the auto closing logic.

the backdrop won't dismiss the dialog, regardless of the state of the form.

Anything you want to highlight for special attention from reviewers?

no

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

[changeset-bot]

🦋 Changeset detected

Latest commit: 11cffd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/view-components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[joshblack]

LGTM but want to confirm with @jonrohan 👀

[HDinger]

Hi @jonrohan are there any updates on this?