Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ActionMenu's itemActivated event bubbles #3268

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

camertron
Copy link
Contributor

@camertron camertron commented Jan 15, 2025

What are you trying to accomplish?

The ActionMenu's itemActivated event does not bubble, making it more difficult to use than necessary. SelectPanel, which was based on ActionMenu, also features an itemActivated event. SelectPanel's event bubbles, so ActionMenu's probably should too.

Integration

No changes necessary in production.

List the issues that this change affects.

Fixes #3269

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: af3317a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review January 15, 2025 20:13
@camertron camertron requested a review from a team as a code owner January 15, 2025 20:13
@camertron camertron requested a review from langermank January 15, 2025 20:13
Copy link

@acbreton acbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫧

@camertron camertron merged commit 43e621e into main Jan 15, 2025
39 checks passed
@camertron camertron deleted the action_menu_item_activated_should_bubble branch January 15, 2025 21:22
@primer primer bot mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bubbles to ActionMenu component
3 participants