-
Notifications
You must be signed in to change notification settings - Fork 125
Fix anchor escaping in call to Regexp.new
#3265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anchor escaping in call to Regexp.new
#3265
Conversation
This should fix classname keys when generating `lib/primer/classify/utilities.yml` with `bundle exec rake utilities:build`. Fixes primer#3263 Relates to primer#3177
|
Regexp.new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this makes sense to me. Thanks! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait, apologies. Could you add a changeset? Just run npx changeset
and folllow the prompts. I'd do it myself but I don't have push access to your branch 😅
@camertron there should already be a changeset - I added it after the fact (see 661e0fe) |
What are you trying to accomplish?
main
due to a regression introduced in Don't instantiate or use Regexp whenstring.start_with?
will do #3177 (308a56b).bundle exec rake utilities:build static:dump
Integration
Not AFAICT.
List the issues that this change affects.
Closes #3263
Risk Assessment
What approach did you choose and why?
Fixes classname keys when generating
lib/primer/classify/utilities.yml
withbundle exec rake utilities:build
.Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Added/updated testsAdded/updated documentationAdded/updated previews (Lookbook)Tested in ChromeTested in FirefoxTested in SafariTested in EdgeTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.