Skip to content

Fix anchor escaping in call to Regexp.new #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Jan 13, 2025

What are you trying to accomplish?

Integration

Not AFAICT.

List the issues that this change affects.

Closes #3263

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Fixes classname keys when generating lib/primer/classify/utilities.yml with bundle exec rake utilities:build.

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

This should fix classname keys when generating `lib/primer/classify/utilities.yml` with `bundle exec rake utilities:build`.

Fixes primer#3263
Relates to primer#3177
@myabc myabc requested a review from a team as a code owner January 13, 2025 11:54
@myabc myabc requested a review from joshblack January 13, 2025 11:54
Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 6720dd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@myabc myabc changed the title Fix anchor escaping in call to Regexp.new Fix anchor escaping in call to `Regexp.new Jan 13, 2025
@myabc myabc changed the title Fix anchor escaping in call to `Regexp.new Fix anchor escaping in call to Regexp.new Jan 13, 2025
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this makes sense to me. Thanks! 🎉

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait, apologies. Could you add a changeset? Just run npx changeset and folllow the prompts. I'd do it myself but I don't have push access to your branch 😅

@myabc
Copy link
Contributor Author

myabc commented Jan 14, 2025

@camertron there should already be a changeset - I added it after the fact (see 661e0fe)

@camertron camertron merged commit 3c2454a into primer:main Jan 14, 2025
30 of 32 checks passed
@primer primer bot mentioned this pull request Jan 14, 2025
@myabc myabc deleted the fix-utilities-build-task-classname-replacement branch February 2, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate static files / rake static:dump is failing on main
3 participants