Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): update styling for caret alignment #3198

Closed
wants to merge 3 commits into from

Conversation

joshblack
Copy link
Member

Context: https://github.com/github/primer/issues/4414

What are you trying to accomplish?

Update the Popover styles so that the caret is styled correctly

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 965e19b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@joshblack joshblack closed this Nov 21, 2024
@joshblack joshblack deleted the fix/update-styling-for-popover-caret branch November 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant