Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for trailing and leading visual icons in Primer::Beta::Link (second try) #3041

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add support for trailing and leading visual icons in Primer::Beta::Link (second try) #3041

wants to merge 12 commits into from

Commits on Aug 30, 2024

  1. Revert "Revert "Add support for trailing and leading visual icons in … 

    …Primer::Beta::Link (primer#2982)" (primer#3040)"

This reverts commit 612307d.
    @HDinger
    HDinger committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    abfbd54 View commit details
    Browse the repository at this point in the history

  2. Remove duplicated trimmed_content method which is now part of `Prim… 

    …er::Component`
    @HDinger
    HDinger committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    8a63255 View commit details
    Browse the repository at this point in the history

  3. Add additional span inside the link to be able to limit the underline… 

    … effect to the actual text instead of overflowing into the white space between text and leading/trailing icons
    @HDinger
    HDinger committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    80b0d8b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into fix/underline-for-link-icons

    @camertron
    camertron committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c107c69 View commit details
    Browse the repository at this point in the history

  2. Generating component snapshots

    @camertron @github-actions
    camertron authored and github-actions[bot] committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    703c8e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Add line-height to ensure correct height of link text

    @HDinger
    HDinger committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    44ae1be View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Merge branch 'main' into fix/underline-for-link-icons

    @camertron
    camertron committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    668970f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'opf/fix/underline-for-link-icons' into … 

    …fix/underline-for-link-icons
    @camertron
    camertron committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f800d09 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/underline-for-link-icons' of github.com:primer/view… 

    …_components into fix/underline-for-link-icons
    @camertron
    camertron committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    94539bd View commit details
    Browse the repository at this point in the history

  4. Reset screenshots

    @camertron
    camertron committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    9ea6c03 View commit details
    Browse the repository at this point in the history

  5. Generating component snapshots

    @camertron @github-actions
    camertron authored and github-actions[bot] committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    403bb08 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Since we don't know where the link is used (Caption, title, body ...)… 

    …, we have to fall back to the browser default "normal" for the line-height instead of using a typography variable
    @HDinger
    HDinger committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    cc5c5f3 View commit details
    Browse the repository at this point in the history