Revert "Add support for trailing and leading visual icons in Primer::Beta::Link (#2982)" #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a16f5a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
HDinger
added a commit
to opf/primer_view_components
that referenced
this pull request
Aug 30, 2024
…Primer::Beta::Link (primer#2982)" (primer#3040)" This reverts commit 612307d.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b5b0199.
Hey @HDinger, apologies! I had to revert this because I found a visual issue with underlining that I think we should address before trying to merge this in again. I didn't notice it before because underlining was turned off in the previews I looked at.
Specifically, this looks a little wonky to me:
The underlined text (initially and on hover) extends past the beginning and end of the text. I think we should probably render the icons outside the
<a>tag itself and set their foreground color to the link color.