Fix layering issues with dialog popover hack #2556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4579ac4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
jonrohan
reviewed
Feb 2, 2024
While the prior fix in `6cc198512c` worked to keep the dialog open, because it called showPopover to open the ancestral popovers, they ended up on the top of the stack, rather than underneath the dialog. This means while the dialog was open, in certain resolutions it can be occluded by its ancestral popups. This new fix instead changes the popovers to be manually controlled, meaning they won't participate in the "hide all popovers" algo, meaning they won't close when the dialog is open. When the dialog closes we turn them back onto auto so that they can continue to have the auto behaviours such as click-outside, escape, etc.
keithamus
force-pushed
the
fix-layering-issues-with-dialog-popover-hack
branch
from
c81ca0a to
f4b64dc
Compare
jonrohan
approved these changes
Feb 2, 2024
keithamus
force-pushed
the
fix-layering-issues-with-dialog-popover-hack
branch
from
1a81705 to
2007ba3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
While the prior fix in
6cc198512cworked to keep the dialog open, because it called showPopover to open the ancestral popovers, they ended up on the top of the stack, rather than underneath the dialog. This means while the dialog was open, in certain resolutions it can be occluded by its ancestral popups.This new fix instead changes the popovers to be manually controlled, meaning they won't participate in the "hide all popovers" algo, meaning they won't close when the dialog is open. When the dialog closes we turn them back onto auto so that they can continue to have the auto behaviours such as click-outside, escape, etc.
Screenshots
See new VRT generated previews
Integration
No
List the issues that this change affects.
Closes # (type the GitHub issue number after #)
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.