Skip to content

Conversation

@gr2m
Copy link
Contributor

@gr2m gr2m commented Oct 14, 2023

as per discussion with @lesliecdubs

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

revert changes from #2030 and #2038

Screenshots

n/a

Integration

no

List the issues that this change affects.

n/a

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

manual revert of changes introduced for release notifications

Anything you want to highlight for special attention from reviewers?

prior discussion and decission occured with @lesliecdubs

Accessibility

n/a

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@gr2m gr2m requested review from a team and keithamus October 14, 2023 16:51
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2023

⚠️ No Changeset found

Latest commit: 14cc1d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gr2m gr2m added the skip changeset Pull requests that don't change the library output label Oct 14, 2023
Copy link
Collaborator

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I please ask for a better PR description? Why are these two PRs being reverted?

@gr2m
Copy link
Contributor Author

gr2m commented Oct 16, 2023

It was a GitHub-internal discussions which is why I didn't link it here. See https://github.com/github/planning-tracking/issues/1977#issuecomment-1724043578 (private hubber repository)

@camertron camertron merged commit 0e7bc4d into main Oct 16, 2023
@camertron camertron deleted the remove-release-notification branch October 16, 2023 18:01
@camertron camertron temporarily deployed to preview October 16, 2023 18:01 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Pull requests that don't change the library output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants