Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primer border update #404

Merged
merged 32 commits into from
Jun 21, 2024
Merged

Primer border update #404

merged 32 commits into from
Jun 21, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 25, 2024 •
edited by mperrotti
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1926c84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mperrotti
mperrotti reviewed May 14, 2024
View reviewed changes
plugins/spacing.js

const sizes = primitivesVariables('spacing')

// Add +-1px to each value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change to support cases where people decrease spacing to accommodate border width?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea in the spacing thing was if someone wrote padding: 7px; we'd fail but also suggest they use --base-size-8 since it's 1 px off from the preferred value

@mperrotti mperrotti marked this pull request as ready for review June 19, 2024 21:24
@mperrotti mperrotti requested a review from a team as a code owner June 19, 2024 21:24
@mperrotti mperrotti requested review from langermank and removed request for a team June 19, 2024 21:24
@jonrohan jonrohan merged commit d1526b5 into main Jun 21, 2024
6 checks passed
@jonrohan jonrohan deleted the primer_border_update branch June 21, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti left review comments

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @mperrotti