Skip to content

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Dec 11, 2025

Reverts #7275 while some changes are made to better integrate with github-ui.

@llastflowers llastflowers requested a review from a team as a code owner December 11, 2025 21:57
@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2025

🦋 Changeset detected

Latest commit: 49f8ccc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 11, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@llastflowers llastflowers added the skip changeset This change does not need a changelog label Dec 11, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/8660

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts performance optimizations for PageLayout pane dragging, reverting back to a React state-based approach from the previous pointer capture and GPU-accelerated implementation. The change affects drag event handling, ARIA attribute management, CSS optimizations, and removes performance testing infrastructure.

Key Changes:

  • Replaced pointer events with mouse events and window-level event listeners for drag handling
  • Changed from direct DOM manipulation to React state updates for width and ARIA attributes
  • Removed CSS containment and GPU acceleration optimizations during drag operations
  • Deleted performance testing stories and removed related e2e test exclusions

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
packages/react/src/PageLayout/PageLayout.tsx Reverted drag implementation from pointer capture to mouse events with React state; removed viewport width tracking; changed ARIA attribute handling from DOM manipulation to React props
packages/react/src/PageLayout/PageLayout.module.css Removed CSS containment and GPU acceleration optimizations; changed to global body-level cursor/selection styles during drag
packages/react/src/PageLayout/__snapshots__/PageLayout.test.tsx.snap Updated snapshots to show --pane-width now rendered in inline styles for all panes
packages/react/src/PageLayout/PageLayout.performance.stories.tsx Deleted entire performance testing story file with drag, keyboard, ARIA, and responsive tests
e2e/components/Axe.test.ts Removed skip entries for deleted performance test stories
Comments suppressed due to low confidence (1)

packages/react/src/PageLayout/PageLayout.performance.stories.tsx:1

  • The deletion of PageLayout.performance.stories.tsx removes test coverage for drag performance, keyboard interactions, ARIA attributes, and responsive constraints. While these were Storybook stories rather than automated tests, they provided important manual testing capabilities and documentation for the drag/resize functionality. Consider adding automated tests (unit or e2e) for the drag functionality to ensure it works correctly, especially given the significant implementation changes in this PR.

@primer-integration
Copy link

🔬 github-ui Integration Test Results

Check Status Details
CI ✅ Passed View run
Projects (Memex) ⏳ Pending Waiting for workflow to complete
VRT ✅ Passed View run

@llastflowers llastflowers added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 12, 2025
@llastflowers
Copy link
Contributor Author

Integration tests are passing but not reporting correctly to this PR 🤔 Skipping manually

@llastflowers llastflowers added the integration-tests: skipped manually Changes in this PR do not require an integration test label Dec 12, 2025
@llastflowers llastflowers added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 335e9e8 Dec 12, 2025
61 checks passed
@llastflowers llastflowers deleted the revert-7275-revert-7274-revert-7251-mc/copilot/sub-pr-7248 branch December 12, 2025 01:15
@primer primer bot mentioned this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants