-
Notifications
You must be signed in to change notification settings - Fork 647
Revert "Revert "Revert "Improve PageLayout pane drag performance with pointer capture and GPU-accelerated transforms""" #7305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Revert "Improve PageLayout pane drag performance with pointer capture and GPU-accelerated transforms""" #7305
Conversation
… pointer…" This reverts commit 822c3e7.
🦋 Changeset detectedLatest commit: 49f8ccc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/8660 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts performance optimizations for PageLayout pane dragging, reverting back to a React state-based approach from the previous pointer capture and GPU-accelerated implementation. The change affects drag event handling, ARIA attribute management, CSS optimizations, and removes performance testing infrastructure.
Key Changes:
- Replaced pointer events with mouse events and window-level event listeners for drag handling
- Changed from direct DOM manipulation to React state updates for width and ARIA attributes
- Removed CSS containment and GPU acceleration optimizations during drag operations
- Deleted performance testing stories and removed related e2e test exclusions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
packages/react/src/PageLayout/PageLayout.tsx |
Reverted drag implementation from pointer capture to mouse events with React state; removed viewport width tracking; changed ARIA attribute handling from DOM manipulation to React props |
packages/react/src/PageLayout/PageLayout.module.css |
Removed CSS containment and GPU acceleration optimizations; changed to global body-level cursor/selection styles during drag |
packages/react/src/PageLayout/__snapshots__/PageLayout.test.tsx.snap |
Updated snapshots to show --pane-width now rendered in inline styles for all panes |
packages/react/src/PageLayout/PageLayout.performance.stories.tsx |
Deleted entire performance testing story file with drag, keyboard, ARIA, and responsive tests |
e2e/components/Axe.test.ts |
Removed skip entries for deleted performance test stories |
Comments suppressed due to low confidence (1)
packages/react/src/PageLayout/PageLayout.performance.stories.tsx:1
- The deletion of PageLayout.performance.stories.tsx removes test coverage for drag performance, keyboard interactions, ARIA attributes, and responsive constraints. While these were Storybook stories rather than automated tests, they provided important manual testing capabilities and documentation for the drag/resize functionality. Consider adding automated tests (unit or e2e) for the drag functionality to ensure it works correctly, especially given the significant implementation changes in this PR.
|
Integration tests are passing but not reporting correctly to this PR 🤔 Skipping manually |
Reverts #7275 while some changes are made to better integrate with
github-ui.