-
Notifications
You must be signed in to change notification settings - Fork 650
Remove support for sx from Details component
#6680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b1474a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes support for the sx prop from the Details component as part of a broader effort to migrate away from the styled-system approach. The change replaces the BoxWithFallback wrapper with a native HTML details element and removes all sx-related type definitions and documentation.
- Removes
sxprop support from theDetailscomponent and its type definitions - Replaces
BoxWithFallbackwrapper with native HTMLdetailselement - Updates documentation and removes deprecated
sxprops from docs.json
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react/src/Details/Details.tsx | Removes sx imports, replaces BoxWithFallback with native details element, updates type definitions |
| packages/react/src/Details/Details.docs.json | Removes deprecated sx prop documentation from component and subcomponent props |
| e2e/components/Details.test.ts | Removes SX Prop Stress Test story from visual regression tests |
| .changeset/strange-knives-study.md | Adds changeset entry for major version bump due to breaking change |
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: make sure to run integration checks 🙏
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/1935 |
|
🟢 ci completed with status |
Closes https://github.com/github/primer/issues/5784
Current
sxusage: 2✅
sxusages are only in repos other than github-ui; those usages have been added to the tracking issueChangelog
Removed
Remove support for
sxfrom theAvatarStackcomponent, and associated stories, docs, and testsRollout strategy
We are using the
@primer/styled-reactcomponent to mitigate removingsxusage. We will make sure usage is updated upstream before merging.Merge checklist