Skip to content

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Aug 27, 2025

Closes https://github.com/github/primer/issues/5784

Current sx usage: 2

sx usages are only in repos other than github-ui; those usages have been added to the tracking issue

Changelog

Removed

Remove support for sx from the AvatarStack component, and associated stories, docs, and tests

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

We are using the @primer/styled-react component to mitigate removing sx usage. We will make sure usage is updated upstream before merging.

Merge checklist

@llastflowers llastflowers self-assigned this Aug 27, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025

🦋 Changeset detected

Latest commit: b1474a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 27, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-6680 August 27, 2025 18:49 Abandoned
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.97 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 88.08 KB (-0.1% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-6680 August 27, 2025 19:03 Inactive
@llastflowers llastflowers marked this pull request as ready for review September 5, 2025 15:43
Copilot AI review requested due to automatic review settings September 5, 2025 15:43
@llastflowers llastflowers requested review from a team as code owners September 5, 2025 15:43
@llastflowers llastflowers requested review from jonrohan and pksjce and removed request for jonrohan September 5, 2025 15:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for the sx prop from the Details component as part of a broader effort to migrate away from the styled-system approach. The change replaces the BoxWithFallback wrapper with a native HTML details element and removes all sx-related type definitions and documentation.

  • Removes sx prop support from the Details component and its type definitions
  • Replaces BoxWithFallback wrapper with native HTML details element
  • Updates documentation and removes deprecated sx props from docs.json

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/Details/Details.tsx Removes sx imports, replaces BoxWithFallback with native details element, updates type definitions
packages/react/src/Details/Details.docs.json Removes deprecated sx prop documentation from component and subcomponent props
e2e/components/Details.test.ts Removes SX Prop Stress Test story from visual regression tests
.changeset/strange-knives-study.md Adds changeset entry for major version bump due to breaking change

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: make sure to run integration checks 🙏

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/1935

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 5, 2025
@llastflowers llastflowers added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 5c30443 Sep 5, 2025
44 checks passed
@llastflowers llastflowers deleted the llastflowers/5784/no-sc-Details branch September 5, 2025 23:47
@primer primer bot mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants