-
Notifications
You must be signed in to change notification settings - Fork 647
Add action and icon prop to SelectPanel message
#6350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1e208f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds optional icon and action props to the SelectPanel message feature to improve user experience and accessibility. The changes enable custom icons for all message variants and provide a proper way to render action buttons that don't confuse screen readers.
- Adds
iconprop to allow custom icons above message titles with fallback to default icons - Adds
actionprop to render action buttons properly instead of as selectable list items - Updates component interfaces and adds comprehensive test coverage
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SelectPanelMessage.tsx | Core component updated to support new icon and action props with conditional rendering |
| SelectPanel.tsx | Interface updated to include new props and pass them to message component |
| SelectPanel.test.tsx | Test component updated to support action testing with new test case added |
| SelectPanel.module.css | Added styling for message action container |
| SelectPanel.features.stories.tsx | Added comprehensive story demonstrating all message variants with icons and actions |
| SelectPanel.docs.json | Updated type documentation to reflect new props |
| sharp-buckets-study.md | Changeset file for minor version release |
Co-authored-by: Copilot <[email protected]>
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/392119 |
|
🟢 golden-jobs completed with status |
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
francinelucca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! small change request
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Closes #5362
Changelog
Adds optional
iconandactionprops toSelectPanelMessageto improve UX and accessibility. Theiconprop allows custom icons for all message variants, the icon will be above the title. Theactionprop addresses the accessibility issue where "Create new item" actions were being rendered asActionList.Itemcomponents, causing screen readers to announce them as selectable list items.New
SelectPanelMessagenow acceptsicon?: React.ComponentType<IconProps>prop for custom icons above the titleSelectPanelMessagenow acceptsaction?: React.ReactElementprop for action buttonsChanged
Removed
Rollout strategy
Testing & Reviewing
Merge checklist