Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PageHeader): Correctly add display prop #5415

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

randall-krauskopf
Copy link
Collaborator

Closes: https://github.com/github/primer/issues/4481

Changelog

Changed

  • Fixed bug for incorrectly displaying display prop for title

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: aadc559

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 11, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@randall-krauskopf randall-krauskopf changed the title correctly add display prop fix(PageHeader): Correctly add display prop Dec 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5415 December 11, 2024 20:01 Inactive
Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.4 KB (+0.09% 🔺)
packages/react/dist/browser.umd.js 103.68 KB (+0.03% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354656

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 11, 2024
@randall-krauskopf randall-krauskopf marked this pull request as ready for review December 11, 2024 20:26
@randall-krauskopf randall-krauskopf requested a review from a team as a code owner December 11, 2024 20:26
@randall-krauskopf
Copy link
Collaborator Author

Integration tests are failing due to unrelated errors

Comment on lines +170 to +172
.Title[data-hidden='true'] {
display: none;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.Title[data-hidden='true'] {
display: none;
}
.Title:where([data-hidden='true']) {
display: none;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants