feat(SideNav): Convert SideNav to CSS modules behind feature flag
#5413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d17a5d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
JelloBagel
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
JelloBagel
force-pushed
the
jellobagel-sidenav-cssmodules
branch
from
97e2bb7 to
193fea4
Compare
JelloBagel
temporarily deployed
to
github-pages
GitHub Actions
Inactive
JelloBagel
force-pushed
the
jellobagel-sidenav-cssmodules
branch
from
0d726b7 to
d17a5d8
Compare
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354611 |
github-actions
bot
added
integration-tests: failing
|
🟢 golden-jobs completed with status |
github-actions
bot
added
integration-tests: passing
joshblack
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4132
Changelog
Changed
SideNavto CSS modules behindprimer_react_css_modules_teamfeature flagRollout strategy
Testing & Reviewing
Merge checklist