Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ButtonGroup changes from last release 37.7.0 #5412

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

jonrohan
Copy link
Member

Reverts #5339
Reverts #5343

This caused some bugs in the ButtonGroup component in production where the ButtonGroup had mixed types button,a

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested review from a team as code owners December 11, 2024 00:01
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: b2e1fa5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 11, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5412 December 11, 2024 00:04 Inactive
Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.59 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 102.94 KB (+0.09% 🔺)

@jonrohan jonrohan enabled auto-merge December 11, 2024 00:27
@jonrohan jonrohan added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit d9e62e9 Dec 11, 2024
46 of 47 checks passed
@jonrohan jonrohan deleted the revert_buttongroup_changes branch December 11, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants