Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Table): update to CSS Modules #5349

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Dec 3, 2024

Closes https://github.com/github/primer/issues/4307

Update Table to CSS Modules behind the team feature flag.

Changelog

New

Changed

  • Update Table to CSS Modules behind a feature flag
  • Update Table sub-components to an easier-to-migrate form of styled-components

Removed

Rollout strategy

  • Minor release

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 1b02ee6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5349 December 3, 2024 22:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5349 December 4, 2024 16:40 Inactive
Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.61 KB (0%)
packages/react/dist/browser.umd.js 103.01 KB (0%)

@joshblack joshblack marked this pull request as ready for review December 4, 2024 16:50
@joshblack joshblack requested a review from a team as a code owner December 4, 2024 16:50
@github-actions github-actions bot temporarily deployed to storybook-preview-5349 December 4, 2024 16:50 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5349 December 9, 2024 18:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5349 December 9, 2024 19:31 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354620

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@joshblack joshblack added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 2c79798 Dec 11, 2024
42 checks passed
@joshblack joshblack deleted the refactor/update-table-to-css-modules branch December 11, 2024 18:13
@primer primer bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants