Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(FormControl): update to include disabled leading visuals #5347

Merged
merged 2 commits into from
Dec 3, 2024
Merged

test(FormControl): update to include disabled leading visuals #5347

merged 2 commits into from
Dec 3, 2024

Conversation

joshblack
Copy link
Member

Update e2e tests to include a visual regression test for disabled leading visuals in form controls

Changelog

New

Changed

  • Update the leading visual storybook example to include disabled labels with leading visuals

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

@joshblack joshblack requested a review from jonrohan December 3, 2024 17:59
@joshblack joshblack requested a review from a team as a code owner December 3, 2024 17:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: eee45e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 3, 2024
@joshblack joshblack added skip changeset This change does not need a changelog update snapshots labels Dec 3, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5347 December 3, 2024 18:02 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.53 KB (0%)
packages/react/dist/browser.umd.js 103.8 KB (0%)

@primer primer bot requested a review from a team as a code owner December 3, 2024 18:10
@primer primer bot requested a review from mperrotti December 3, 2024 18:10
@joshblack joshblack added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 17637a8 Dec 3, 2024
43 checks passed
@joshblack joshblack deleted the test/add-missing-form-control-vrt branch December 3, 2024 21:37
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "test(FormControl): update to include disabled leading visuals (…
916789d 
…#5347)"

This reverts commit 17637a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @jonrohan