Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(BaseStyles): Add vrt tests #5346

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

JelloBagel
Copy link
Contributor

@JelloBagel JelloBagel commented Dec 3, 2024

Related to https://github.com/github/primer/issues/4358

Changelog

New

Add VRT tests for BaseStyles component to regression test for CSS Module migration.

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Dec 3, 2024

⚠️ No Changeset found

Latest commit: 1f37a53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.57 KB (0%)
packages/react/dist/browser.umd.js 103.88 KB (0%)

@primer primer bot temporarily deployed to github-pages December 3, 2024 18:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5346 December 3, 2024 18:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5346 December 3, 2024 19:07 Inactive
@JelloBagel JelloBagel added the skip changeset This change does not need a changelog label Dec 3, 2024
Copy link
Collaborator

@randall-krauskopf randall-krauskopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@JelloBagel JelloBagel changed the title Add tests for basestyles chore(BaseStyles): Add vrt tests Dec 3, 2024
@JelloBagel JelloBagel marked this pull request as ready for review December 3, 2024 19:21
@JelloBagel JelloBagel requested review from a team as code owners December 3, 2024 19:21
@JelloBagel JelloBagel requested a review from langermank December 3, 2024 19:21
@randall-krauskopf randall-krauskopf self-requested a review December 3, 2024 19:23
@JelloBagel JelloBagel requested review from jonrohan, joshblack and a team December 3, 2024 19:24
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ Nice!

@jonrohan jonrohan added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@JelloBagel JelloBagel added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 4bb159b Dec 3, 2024
47 checks passed
@JelloBagel JelloBagel deleted the jellobagel-basestyles-vrt branch December 3, 2024 22:07
francinelucca added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants