Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix *.docs.json stories #5345

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Dec 3, 2024

Closes https://github.com/github/primer/issues/4433

Some story IDs are listed incorrectly in their respective *.docs.json, this PR fixes them so that they can be pulled into primer.style storybook embed

Changelog

Changed

  • Update story ids in some components' *.docs.json files

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Test deployment: https://primer-e313264adc-26441320.drafts.github.io/components/data-table/react/alpha

Merge checklist

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 4e6e6b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Dec 3, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5345 December 3, 2024 02:54 Inactive
Copy link
Contributor

github-actions bot commented Dec 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.73 KB (0%)
packages/react/dist/browser.umd.js 104.06 KB (0%)

@francinelucca francinelucca added the docs Documentation label Dec 3, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5345 December 3, 2024 21:43 Inactive
@francinelucca francinelucca marked this pull request as ready for review December 3, 2024 21:53
@francinelucca francinelucca requested a review from a team as a code owner December 3, 2024 21:53
…s-in-primer-docs-for-prc-actionbar-and-datatable
Copy link
Contributor

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✨

@francinelucca francinelucca added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit e231b5f Dec 3, 2024
43 checks passed
@francinelucca francinelucca deleted the francinelucca/4433-bug-fix-storybook-examples-in-primer-docs-for-prc-actionbar-and-datatable branch December 3, 2024 22:48
@primer primer bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation staff Author is a staff member status: review needed status: wip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants