-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix *.docs.json stories #5345
Merged
francinelucca
merged 4 commits into
main
from
francinelucca/4433-bug-fix-storybook-examples-in-primer-docs-for-prc-actionbar-and-datatable
Dec 3, 2024
Merged
docs: fix *.docs.json stories #5345
francinelucca
merged 4 commits into
main
from
francinelucca/4433-bug-fix-storybook-examples-in-primer-docs-for-prc-actionbar-and-datatable
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4e6e6b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
francinelucca
temporarily deployed
to
github-pages
December 3, 2024 02:53
— with
GitHub Actions
Inactive
size-limit report 📦
|
francinelucca
temporarily deployed
to
github-pages
December 3, 2024 21:43
— with
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
December 3, 2024 22:18
— with
GitHub Actions
Inactive
…s-in-primer-docs-for-prc-actionbar-and-datatable
TylerJDev
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ✨
francinelucca
deleted the
francinelucca/4433-bug-fix-storybook-examples-in-primer-docs-for-prc-actionbar-and-datatable
branch
December 3, 2024 22:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4433
Some story IDs are listed incorrectly in their respective *.docs.json, this PR fixes them so that they can be pulled into primer.style storybook embed
Changelog
Changed
Rollout strategy
Testing & Reviewing
Test deployment: https://primer-e313264adc-26441320.drafts.github.io/components/data-table/react/alpha
Merge checklist