Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FormControl): update existing code for sub-components to prep for migration #5342

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Dec 2, 2024

Update FormControl sub-components to be easier to migrate to CSS modules.

Changelog

New

Changed

  • Update the following FormControl sub-components to a different styled component style:
    • Label
    • Caption
    • LeadingVisual
    • Validation

Removed

Rollout strategy

  • Minor release

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: dbd9e32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5342 December 3, 2024 16:30 Inactive
Copy link
Contributor

github-actions bot commented Dec 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.91 KB (+0.18% 🔺)
packages/react/dist/browser.umd.js 104.33 KB (+0.27% 🔺)

@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353326

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 3, 2024
@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@joshblack joshblack requested a review from jonrohan December 3, 2024 17:56
@joshblack joshblack marked this pull request as ready for review December 3, 2024 17:56
@joshblack joshblack requested a review from a team as a code owner December 3, 2024 17:56
@github-actions github-actions bot temporarily deployed to storybook-preview-5342 December 3, 2024 17:58 Inactive
package.json Show resolved Hide resolved
packages/react/src/internal/components/InputLabel.tsx Outdated Show resolved Hide resolved
Merged via the queue into main with commit 39df71e Dec 4, 2024
43 checks passed
@joshblack joshblack deleted the refactor/form-control-css-1 branch December 4, 2024 16:42
@primer primer bot mentioned this pull request Dec 4, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
francinelucca added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants