feat(Overlay): Convert Overlay to CSS modules behind team feature flag #5310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c61f977 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…thub.com:primer/react into francinelucca/4135-update-overlay-to-css-modules
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
reviewed
Nov 19, 2024
| box-shadow: var(--shadow-floating-small); | ||
| animation: overlay-appear 200ms cubic-bezier(0.33, 1, 0.68, 1); | ||
|
|
||
| @keyframes overlay-appear { |
There was a problem hiding this comment.
@keframes need to be outside of a wrapper div (you can just throw them at the end)
Co-authored-by: Katie Langerman <[email protected]>
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4135
Changelog
New
Overlaydev story to testsxandstyleprops with VRTOverlaymodule cssChanged
Overlayto use CSS modules when team feature flag is turned onRollout strategy
Testing & Reviewing
Merge checklist