Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stories for Octicon usage #5244

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Add stories for Octicon usage #5244

merged 3 commits into from
Dec 19, 2024

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Nov 6, 2024 •
edited
Loading

Adds stories to demonstrate how to customize Octicons.

  • Size
  • Fill
  • Classname
Screenshot of Storybook stories for octicons

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a79e2d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5244 November 6, 2024 22:30 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.63 KB (0%)
packages/react/dist/browser.umd.js 104.85 KB (0%)

@langermank langermank added the skip changeset This change does not need a changelog label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 19, 2024
@langermank langermank marked this pull request as ready for review December 19, 2024 15:53
@langermank langermank requested a review from a team as a code owner December 19, 2024 15:53
@langermank langermank added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit e1808ec Dec 19, 2024
46 of 47 checks passed
@langermank langermank deleted the icon-customization-stories branch December 19, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti mperrotti approved these changes

@francinelucca francinelucca Awaiting requested review from francinelucca francinelucca is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @mperrotti