Add bg prop to ProgressBar.Item #5007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ef06ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lukasoppermann
added a commit
to primer/eslint-plugin-primer-react
that referenced
this pull request
Sep 23, 2024
Merge this once primer/react#5007 is merged
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
@lukasoppermann/progressbar
branch
from
71530f0 to
09c95e3
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
lukasoppermann
force-pushed
the
@lukasoppermann/progressbar
branch
from
09c95e3 to
623c2de
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
@lukasoppermann/progressbar
branch
from
623c2de to
0a88699
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
added a commit
to primer/eslint-plugin-primer-react
that referenced
this pull request
Sep 23, 2024
* Add bg for ProgressBar.item Merge this once primer/react#5007 is merged * Create beige-schools-horse.md
siddharthkp
requested changes
Sep 23, 2024
Member
siddharthkp
left a comment
siddharthkp
left a comment
There was a problem hiding this comment.
Request some minor improvements
Co-authored-by: Siddharth Kshetrapal <[email protected]>
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
reviewed
Sep 24, 2024
| if (args.bg && args.bg !== '') { | ||
| setSectionColors([args.bg, ...sectionColorsDefault]) | ||
| } | ||
| }, [args.bg]) |
Member
There was a problem hiding this comment.
(non blocker, nit picking) Didn't really understand what this block of code does, can you help me?
Contributor
Author
There was a problem hiding this comment.
Needed to avoid error: "To many re-renders"
siddharthkp
approved these changes
Sep 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
bgprop for onProgressBar.Itemas discussed in https://github.slack.com/archives/GACAW0NPM/p1726839001767409Follow-up task
Changelog
bgprop for onProgressBar.ItemRollout strategy
Testing & Reviewing
Merge checklist