Skip to content

Bump primer/primitives to v9 #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
langermank merged 8 commits into from
Aug 26, 2024
Merged

Bump primer/primitives to v9 #4884

langermank merged 8 commits into from
Aug 26, 2024

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Aug 26, 2024 •
edited
Loading

Bumping to the latest.

Note to reviewer:

I know the snapshots look scary. Two things:

  1. This has been shipped in dotcom for a few weeks, I'm just catching Primer libraries up 😄
  2. I reviewed all images and it looks correct

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1af6b28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.34 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 96.61 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4884 August 26, 2024 17:22 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2024
@primer primer bot temporarily deployed to github-pages August 26, 2024 17:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4884 August 26, 2024 17:32 Inactive
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4884 August 26, 2024 17:58 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2024
@primer primer bot temporarily deployed to github-pages August 26, 2024 18:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4884 August 26, 2024 18:08 Inactive
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4884 August 26, 2024 18:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4884 August 26, 2024 18:38 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 26, 2024
@primer primer bot temporarily deployed to github-pages August 26, 2024 18:44 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4884 August 26, 2024 18:44 Inactive
@langermank langermank marked this pull request as ready for review August 26, 2024 19:09
@langermank langermank requested review from a team as code owners August 26, 2024 19:09
@langermank langermank added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 46dc2f3 Aug 26, 2024
@langermank langermank deleted the bump-prim-v9.2 branch August 26, 2024 20:07
@primer primer bot mentioned this pull request Aug 23, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

@TylerJDev TylerJDev Awaiting requested review from TylerJDev TylerJDev is a code owner automatically assigned from primer/engineer-reviewers

+1 more reviewer

@tbenning tbenning tbenning approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@langermank @jonrohan @tbenning