Skip to content

Conversation

@TylerJDev
Copy link
Member

Closes https://github.com/github/primer/issues/3353

In most cases when using Timeline, consumers will keep the icons decorative, but since the stories for Timeline don't have much context, we can add text alternatives to the icons so that the meaning is conveyed properly.

Changelog

Changed

  • Adds text alternatives to icons in Timeline stories

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Aug 7, 2024
@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: b341344

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev changed the title Add text alternatives to icons in Timeline stories Timeline: Add text alternatives to icons in Timeline stories Aug 7, 2024
@TylerJDev TylerJDev marked this pull request as ready for review August 7, 2024 14:15
@TylerJDev TylerJDev requested a review from a team as a code owner August 7, 2024 14:15
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.8 KB (0%)
packages/react/dist/browser.umd.js 96.19 KB (0%)

@TylerJDev TylerJDev added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 75cbb2a Aug 9, 2024
@TylerJDev TylerJDev deleted the tylerjdev/timeline-icon-text-alternatives branch August 9, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants