Trigger onClose when Dialog backdrop is clicked #4565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1645a6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dgreif
force-pushed
the
dg/dialog-backdrop-click
branch
from
94f7fa2 to
1107686
Compare
Contributor
size-limit report 📦
|
joshblack
approved these changes
May 8, 2024
Merged
joshblack
added a commit
that referenced
this pull request
May 10, 2024
This reverts commit 564db1d.
JelloBagel
pushed a commit
that referenced
this pull request
May 16, 2024
* Trigger onClose when Dialog backdrop is clicked * Update docs with new backdrop gesture
JelloBagel
pushed a commit
that referenced
this pull request
May 16, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/github/primer/issues/2531
Relates to https://github.com/github/repos/issues/9248
Alternative to https://github.com/github/primer/issues/1838
I'd like to allow the v2 Dialog to be closed by clicking on the backdrop overlay. This is currently not supported, though the v1 Dialog and PVC dialog support this behavior.
Based on the usage guidelines, there are some unique cases where clicking the backdrop should not close the dialog. By passing in a new
backdropgesture, there is an escape hatch for these unique cases to ignorebackdropevents on a case-by-case basis.Changelog
New
Dialog and ConfirmationDialog can now be closed by clicking on the backdrop round the dialog. This will cause
onCloseto be called with a new'backdrop'gesture.Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist