[Do not review] Ensure button counter is announced #4533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
size-limit report 📦
|
khiga8
changed the title
khiga8
commented
Apr 29, 2024
| @@ -1,6 +1,7 @@ | |||
| import {EyeIcon, TriangleDownIcon, HeartIcon} from '@primer/octicons-react' | |||
| import React, {useState} from 'react' | |||
| import React, {useState, useRef} from 'react' | |||
Contributor
Author
There was a problem hiding this comment.
Suggested change
| import React, {useState, useRef} from 'react' | |
| import React, {useRef} from 'react' |
khiga8
commented
Apr 30, 2024
khiga8
commented
May 1, 2024
| import React, {useState} from 'react' | ||
| import React, {useState, useRef} from 'react' | ||
| import {Button} from '.' | ||
| import {announce} from '@primer/live-region-element' |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| import {announce} from '@primer/live-region-element' | |
| import {announce} from '@primer/live-region-element | |
| test test |
Contributor
Author
|
Superceded by:#4537! Also see: Document results for various implementations for communicating dynamically updated buttons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just has a bunch of different test cases, to inform https://github.com/github/accessibility/pull/6222.