Bug: aria-invalid is overriden in TextInput
#4365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 27dacd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
jonrohan
approved these changes
Mar 7, 2024
Member
jonrohan
left a comment
jonrohan
left a comment
There was a problem hiding this comment.
Ah, the inputProps splat overriding 👍🏻 ⚡ thanks for the fix
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Add failing test * Add failing test * Add fix * Create grumpy-shirts-march.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release 36.11.0, we see that integration tests are failing.
If we look closer into https://github.com/github/github/actions/runs/8180619423/job/22369116712?pr=315110
the root cause seems to be that the provided
aria-invalidprop is being overriden byTextInput. This is introduced in 15c078d#diff-02ef2a0d53f758cb1d0e24c286118bae352cfdae3d88635258903638aca68d04This PR will change the order of the props to fix it. No visual changes.
Rollout strategy
Testing & Reviewing
Merge checklist