Skip to content

Conversation

@joshblack
Copy link
Member

Add a section to our versioning docs to include landmark roles as they relate to semver.

Feedback

Would love to hear what you all think about this section and if it accurately captures our semver policy 👀 Let me know if there is anything missing or anything that needs to be changed!

@joshblack joshblack requested review from a team, broccolinisoup and siddharthkp September 13, 2023 17:09
@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

⚠️ No Changeset found

Latest commit: 49ed88b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 100.7 KB (0%)
dist/browser.umd.js 101.29 KB (0%)

@joshblack joshblack temporarily deployed to github-pages September 13, 2023 17:15 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3743 September 13, 2023 17:15 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this 🔥 My only feedback/question is that should we elaborate what we mean by "potentially major" under the semver section? 👀

Copy link
Member

@TylerJDev TylerJDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✨

Off-topic, but it might be worth a discussion in the future to see if we should steer clear from having default landmarks all together in components and always give that choice to the consumer? This doesn't seem to be the norm in newer components, but I do see the friction that could be caused through updates such as with PageLayout and others. I really like the approach done in the fix #3737 and I wonder if it could be applied elsewhere 🤔

Copy link
Contributor

@iansan5653 iansan5653 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@joshblack
Copy link
Member Author

@TylerJDev totally agreed, I think you're dead-on that we probably shouldn't be baking in default landmark roles. Let me see where would a good place be to capture that so that we consider it in future component work 👀 (or let me know if you have any places in mind where it may be good to capture this!)

@joshblack joshblack added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 0ff78af Sep 15, 2023
@joshblack joshblack deleted the docs/add-semantics-to-versioning branch September 15, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants