Skip to content

Button: Fix storybook playground, add missing e2e tests #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
siddharthkp merged 9 commits into from
Apr 28, 2023
Merged

Button: Fix storybook playground, add missing e2e tests #3226

siddharthkp merged 9 commits into from
Apr 28, 2023

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Apr 26, 2023 •
edited
Loading

Breaking #3065 into small parts to make PRs easier to maintain and review

  • fix Button playground
  • fix drafts/Button metadata
  • remove IconButton and LinkButton from drafts (they will come later)
  • add missing stories to e2e tests

@changeset-bot

This comment was marked as outdated.

Sign in to view
@siddharthkp siddharthkp self-assigned this Apr 26, 2023
@siddharthkp siddharthkp added skip changeset This change does not need a changelog update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Apr 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 121.18 KB (0%)
dist/browser.umd.js 121.47 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3226 April 26, 2023 13:36 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 26, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-3226 April 26, 2023 13:39 Inactive
@siddharthkp siddharthkp requested a review from colebemis April 26, 2023 13:40
@siddharthkp siddharthkp marked this pull request as ready for review April 26, 2023 13:40
@siddharthkp siddharthkp requested a review from a team April 26, 2023 13:40
@primer primer bot temporarily deployed to github-pages April 26, 2023 13:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3226 April 26, 2023 13:44 Inactive
@siddharthkp siddharthkp mentioned this pull request Apr 26, 2023
Merged
@siddharthkp siddharthkp temporarily deployed to github-pages April 26, 2023 14:18 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3226 April 26, 2023 14:19 Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Apr 28, 2023
@siddharthkp siddharthkp changed the title Prep for css Button Internal: Button: Fix storybook playground, add e2e tests Apr 28, 2023
@siddharthkp siddharthkp changed the title Internal: Button: Fix storybook playground, add e2e tests Button: Fix storybook playground, add e2e tests Apr 28, 2023
@siddharthkp siddharthkp changed the title Button: Fix storybook playground, add e2e tests Button: Fix storybook playground, add missing e2e tests Apr 28, 2023
Merged via the queue into main with commit ee4e6d1 Apr 28, 2023
@siddharthkp siddharthkp deleted the prep-css-button branch April 28, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@siddharthkp siddharthkp

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp @colebemis